 |
Home | Changes | Index | Search | Go
Notes/API for Internal Review
Reference API as HTML:
Feedback from Internal Review:
- While this component is button like, it does not honor the contract of JButton (no icons, no rollovers, etc) so it should be changed to be a subclass of JComponet instead.
- The change to be a subclass of JComponent means it needs to add it's own support for mouse click handling.
- Since it is a clone of NSColorWell? the name should change to JXColorWell?. Also, it's not a button anymore so this makes sense.
- Keeping the dialog and chooser reference around causes a possible memory leak, or at least wasted memory.
- Rather than having get/setChooser, it should have a protected JColorChooser? createChooser() method which subclasses can override if they need to customize the chooser in some way.
- There should be a title property for the dialog used internally
- Instead of using the background color it should just use a new property called 'color'
- It shouldn't use EyeDropperColorPanel? by default, or at least it should check if it's actually available.
Feedback from External Review (forum link goes here):
|